On 2021-06-02 15:23, Stanimir Varbanov wrote:
Mansur, could you answer to Bryan's comments?
On 5/28/21 8:23 PM, Bryan O'Donoghue wrote:
On 28/05/2021 10:48, Mansur Alisha Shaik wrote:
Do not set constrained format explicitly for UBWC
Signed-off-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx>
Could you give a little bit more detail on why, what the side effects
are ?
Sorry for late response, by default for NV12_UBWC is 128x32
Should this be a Fixes: ?
without this fix on V6, firmware throws below SFR
qcom-venus aa00000.video-codec: SFR message from FW:
QC_IMAGE_VERSION_STRING=video-firmware.1.0-df9cb37cf8e507a4468265658702247652351a49
Err_Fatal -
/local/mnt/workspace/pkg/builds/dynamic_timely/tree2/vendor/qcom/proprietary/video-firmware-noship/venus_proc/venus/decoders/common/src/video_decoder.c:6644:2fef3
which result in playback happens through Software codec.
---
drivers/media/platform/qcom/venus/helpers.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/helpers.c
b/drivers/media/platform/qcom/venus/helpers.c
index b813d6dba..e4b8a2a 100644
--- a/drivers/media/platform/qcom/venus/helpers.c
+++ b/drivers/media/platform/qcom/venus/helpers.c
@@ -1138,8 +1138,12 @@ int
venus_helper_set_format_constraints(struct
venus_inst *inst)
if (!IS_V6(inst->core))
return 0;
+ if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC)
+ return 0;
+
pconstraint.buffer_type = HFI_BUFFER_OUTPUT2;
pconstraint.num_planes = 2;
+
Additional newline should be removed.
pconstraint.plane_format[0].stride_multiples = 128;
pconstraint.plane_format[0].max_stride = 8192;
pconstraint.plane_format[0].min_plane_buffer_height_multiple =
32;
---
bod
