Re: [PATCH v2 0/6] Camera Sensor Drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martina,

On Thu, May 27, 2021 at 03:21:39PM +0100, Martina Krasteva wrote:
> From: Martina Krasteva <martinax.krasteva@xxxxxxxxx>
> 
> Patch series contains Sony IMX335, Sony IMX412 and OmniVision OV9282
> camera sensor drivers and respective binding documentation.
> 
> v1->v2:
> - define maxItems for reset-gpios in dt binding document
> - make sure the device is powered off on remove
> - use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
> 
> v1: https://patchwork.kernel.org/project/linux-media/list/?series=458115

Thanks for the update.

The patches seem fine, but I noticed one problem: the analogue gain is only
updated when exposure is set. This is a bug.

Most drivers do not try to synchronise setting analogue gain and exposure
to the same frame. Do you need that? Alternatively the control framework
would probably need to be amended a little --- something that would have
other benefits, too.

I don't think that blocks merging the drivers though. But this needs to be
addressed.

-- 
Kind regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux