Add the ro_requests module option to test Read-Only Requests with vivid.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
---
Documentation/admin-guide/media/vivid.rst | 10 ++++++++++
drivers/media/test-drivers/vivid/vivid-core.c | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/Documentation/admin-guide/media/vivid.rst b/Documentation/admin-guide/media/vivid.rst
index 6d7175f96f74..423a61797a1d 100644
--- a/Documentation/admin-guide/media/vivid.rst
+++ b/Documentation/admin-guide/media/vivid.rst
@@ -302,6 +302,16 @@ all configurable using the following module options:
- 0: forbid hints
- 1: allow hints
+- ro_requests:
+
+ specifies if the capture device supports the standard Request API (i.e.
+ userspace can set controls in a request before queueing it), or
+ the Read-Only Request API (userspace can only read back controls after
+ the request was completed). Default is 0.
+
+ - 0: regular requests
+ - 1: read-only requests
+
Taken together, all these module options allow you to precisely customize
the driver behavior and test your application with all sorts of permutations.
It is also very suitable to emulate hardware that is not yet available, e.g.
diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c
index ca0ebf6ad9cc..641d8c75e8c9 100644
--- a/drivers/media/test-drivers/vivid/vivid-core.c
+++ b/drivers/media/test-drivers/vivid/vivid-core.c
@@ -177,6 +177,14 @@ MODULE_PARM_DESC(cache_hints, " user-space cache hints, default is 0.\n"
"\t\t 0 == forbid\n"
"\t\t 1 == allow");
+static unsigned int ro_requests[VIVID_MAX_DEVS] = {
+ [0 ... (VIVID_MAX_DEVS - 1)] = 0
+};
+module_param_array(ro_requests, uint, NULL, 0444);
+MODULE_PARM_DESC(ro_requests, " use read-only requests for video capture instead of regular requests, default is 0.\n"
+ "\t\t 0 == regular requests\n"
+ "\t\t 1 == read-only requests");
+
static struct vivid_dev *vivid_devs[VIVID_MAX_DEVS];
const struct v4l2_rect vivid_min_rect = {
@@ -847,6 +855,8 @@ static int vivid_create_queue(struct vivid_dev *dev,
q->lock = &dev->mutex;
q->dev = dev->v4l2_dev.dev;
q->supports_requests = true;
+ if (V4L2_TYPE_IS_CAPTURE(buf_type))
+ q->supports_ro_requests = (ro_requests[dev->inst] == 1);
q->allow_cache_hints = (cache_hints[dev->inst] == 1);
return vb2_queue_init(q);
--
2.30.2
