On Tue, Jun 01, 2021 at 10:20:05PM +0800, Zheng Yongjun wrote:
> Eliminate the following coccicheck warning:
>
> drivers/staging/media/atomisp/pci/sh_css_firmware.c:369:4-10: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index f4ce8ace9d50..980fc09fcc8b 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -365,8 +365,7 @@ void sh_css_unload_firmware(void)
> for (i = 0; i < sh_css_num_binaries; i++) {
> if (fw_minibuffer[i].name)
> kfree((void *)fw_minibuffer[i].name);
Change this too.
> - if (fw_minibuffer[i].buffer)
> - kvfree(fw_minibuffer[i].buffer);
> + kvfree(fw_minibuffer[i].buffer);
> }
> kfree(fw_minibuffer);
> fw_minibuffer = NULL;
regards,
dan carpenter
