On Mon, May 17, 2010 at 04:58:00PM +0300, Baruch Siach wrote: > Hi Sascha, > > Thanks for your comments. > > On Mon, May 17, 2010 at 09:27:20AM +0200, Sascha Hauer wrote: > > On Wed, May 12, 2010 at 09:02:29PM +0200, Guennadi Liakhovetski wrote: > > > Hi Baruch > > > > > > Thanks for eventually mainlining this driver! A couple of comments below. > > > Sascha, would be great, if you could get it tested on imx27 with and > > > without emma. > > > > I will see what I can do. Testing and probably breathing life into a > > camera driver usually takes me two days given that the platform support > > is very outdated. I hope our customer is interested in this, then it > > would be possible to test it. > > > > > BTW, if you say, that you use emma to avoid using the > > > standard DMA controller, why would anyone want not to use emma? Resource > > > conflict? There is also a question for you down in the comments, please, > > > skim over. > > > > I originally did not know how all the components should work together. > > Now I think it's the right way to use the EMMA to be able to scale > > images and to do colour conversions (which does not work with our Bayer > > format cameras, so I cannot test it). > > So can I remove the non EMMA code from this driver? This will simplify the > code quite a bit. Please don't. I had a talk with our customer and it seems I can put some effort into the i.MX27 part. That's good news because I also want this driver mainline. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
