Hi Geert, On 2021-05-17 11:51:48 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Thu, May 13, 2021 at 4:10 PM Niklas Söderlund > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > > Enable support for M3-W+ (r8a77961). > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > Tested-by: LUU HOAI <hoai.luu.ub@xxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > --- > > * Changes since v1 > > - Do not piggy back on the M3-W (r8a7796) quirks as they are different. > > But for now they're still handled the same way... > > > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > > @@ -1112,6 +1112,11 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a7796 = { > > .num_channels = 4, > > }; > > > > +static const struct rcar_csi2_info rcar_csi2_info_r8a77961 = { > > + .hsfreqrange = hsfreqrange_m3w_h3es1, > > + .num_channels = 4, > > +}; > > ... as rcar_csi2_info_r8a77961 has the same contents as rcar_csi2_info_r8a7796? Yes the structures are currently the same but the one added here is correct while rcar_csi2_info_r8a7796 will need a new qurik field added in a different patch. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Niklas Söderlund