Le jeudi 13 mai 2021 à 17:05 +0900, Alexandre Courbot a écrit : > Hi Hans, thanks for the review! > > On Thu, Apr 29, 2021 at 4:28 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > > > > On 27/04/2021 13:15, Alexandre Courbot wrote: > > > From: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx> > > > > > > The stateless API requires a media device for issuing requests. Add one > > > if we are being instantiated as a stateless decoder. > > > > Why for the stateless decoder only? Why not create one for all? > > > > It's not a blocker, but I would recommend looking at this. > > Would there be any use in creating a media device for a stateful > decoder that does not need to use requests? The only thing I can think of is classification. In GStreamer support for stateless decoders, I use the topology to classify what is a decoder by walking the toplogy and making sure it's what I expect, and that there is no other branches or functions that I may not support. This makes it more strict, so less likely to confuse driver function. Note that v4l2-compliance just use the same old heuristic we have used for stateful, which is to check that one side have only RAW format, and the other side have only encoded formats. It works too, it's just less strict. > > Cheers, > Alex.
