On Wed, 28 Apr 2021 16:51:48 +0200
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
> drivers/media/i2c/ak7375.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/media/i2c/ak7375.c b/drivers/media/i2c/ak7375.c
> index e1f94ee0f48f..40b1a4aa846c 100644
> --- a/drivers/media/i2c/ak7375.c
> +++ b/drivers/media/i2c/ak7375.c
> @@ -87,15 +87,7 @@ static const struct v4l2_ctrl_ops ak7375_vcm_ctrl_ops = {
>
> static int ak7375_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> {
> - int ret;
> -
> - ret = pm_runtime_get_sync(sd->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(sd->dev);
> - return ret;
> - }
> -
> - return 0;
> + return pm_runtime_resume_and_get(sd->dev);
> }
>
> static int ak7375_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
