Re: [PATCH] af9015 : more robust eeprom parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Terve!
And sorry I have been "out of the office" for few months... Now I am back and I think I have again time for this project...

On 03/21/2010 01:14 PM, matthieu castet wrote:
the af9015 eeprom parsing accept 0x38 as 2nd demodulator. But this is
impossible because the
first one is already hardcoded to 0x38.
This remove a special case for AverMedia AVerTV Volar Black HD.

I don't like this. It adds one more rather unnecessary if(). Of course we can validity check many kind of values from eeprom but I think it is not rather wise. Just trust eeprom and if there is device which does have garbage content in eeprom then add special case for that broken device. Currently AverMedia AVerTV Volar Black HD (A850) is only device I know which does have bad eeprom content.

Also in af9015_copy_firmware don't hardcode the 2nd demodulator address
to 0x3a.

This one looks good.



Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx>

regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux