On Tue, Apr 20, 2021 at 10:44:48AM +0200, Fabio Aiuto wrote: > On Tue, Apr 20, 2021 at 12:45:04AM +0530, Deepak R Varma wrote: > > switch(AnalogGain) > > { > > case 0: > > @@ -1069,8 +1071,9 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > > */ > > if (DigitalGain >= 16 || DigitalGain <= 1) > > DigitalGain = 1; > > - /* AnalogGainToWrite = > > - (u16)((DigitalGain << 12) | AnalogGainToWrite); */ > > + > > + /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite); > > + */ > > this is best recommended for one line comment: > > /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite); */ > I'm going through old emails... Just delete all commented out code. regards, dan carpenter