Hi Pawel, On Wednesday 12 May 2010 10:36:24 Pawel Osciak wrote: > > Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > >The videobuf_dmabuf and videobuf_vmalloc_memory fields have a vmalloc > >field to store the kernel virtual address of vmalloc'ed buffers. Rename > >the field to vaddr. [snip] > I am not 100% sure about this, it is a bit different from the rename > of vmalloc to vaddr for functions made by Hans earlier. Those functions > were supposed to return kernel addresses to buffers and callers did not > need to know where did those pointers had come from, but keeping that > information here might be useful/prevent confusion... I'd still rename the field, but I have no strong opinion about it. If you think the patch should be dropped, that's fine. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
