RE: [PATCH 6/7] v4l: videobuf: Remove videobuf_mapping start and end fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

>Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
>The fields are assigned but never used, remove them.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>---
> drivers/media/video/videobuf-dma-contig.c |    2 --
> drivers/media/video/videobuf-dma-sg.c     |    2 --
> drivers/media/video/videobuf-vmalloc.c    |    2 --
> include/media/videobuf-core.h             |    2 --
> 4 files changed, 0 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/media/video/videobuf-dma-contig.c
>b/drivers/media/video/videobuf-dma-contig.c
>index d87ed21..c5d2552 100644
>--- a/drivers/media/video/videobuf-dma-contig.c
>+++ b/drivers/media/video/videobuf-dma-contig.c
>@@ -279,8 +279,6 @@ static int __videobuf_mmap_mapper(struct videobuf_queue
>*q,
> 		return -ENOMEM;
>
> 	buf->map = map;
>-	map->start = vma->vm_start;
>-	map->end = vma->vm_end;
> 	map->q = q;
>
> 	buf->baddr = vma->vm_start;
>diff --git a/drivers/media/video/videobuf-dma-sg.c
>b/drivers/media/video/videobuf-dma-sg.c
>index 8924e51..2d64040 100644
>--- a/drivers/media/video/videobuf-dma-sg.c
>+++ b/drivers/media/video/videobuf-dma-sg.c
>@@ -608,8 +608,6 @@ static int __videobuf_mmap_mapper(struct videobuf_queue
>*q,
> 	}
>
> 	map->count    = 1;
>-	map->start    = vma->vm_start;
>-	map->end      = vma->vm_end;
> 	map->q        = q;
> 	vma->vm_ops   = &videobuf_vm_ops;
> 	vma->vm_flags |= VM_DONTEXPAND | VM_RESERVED;
>diff --git a/drivers/media/video/videobuf-vmalloc.c
>b/drivers/media/video/videobuf-vmalloc.c
>index cf5be6b..f0d7cb8 100644
>--- a/drivers/media/video/videobuf-vmalloc.c
>+++ b/drivers/media/video/videobuf-vmalloc.c
>@@ -245,8 +245,6 @@ static int __videobuf_mmap_mapper(struct videobuf_queue
>*q,
> 		return -ENOMEM;
>
> 	buf->map = map;
>-	map->start = vma->vm_start;
>-	map->end   = vma->vm_end;
> 	map->q     = q;
>
> 	buf->baddr = vma->vm_start;
>diff --git a/include/media/videobuf-core.h b/include/media/videobuf-core.h
>index a157cd1..f2c41ce 100644
>--- a/include/media/videobuf-core.h
>+++ b/include/media/videobuf-core.h
>@@ -54,8 +54,6 @@ struct videobuf_queue;
>
> struct videobuf_mapping {
> 	unsigned int count;
>-	unsigned long start;
>-	unsigned long end;
> 	struct videobuf_queue *q;
> };
>
>--
>1.6.4.4


ack, I see no reason to keep them either.


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center





--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux