Re: [PATCH v5 11/24] media: entity: Skip link validation for pads to which there is no route to

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/04/2021 14:41, Sakari Ailus wrote:
Hi Laurent,

On Sun, Apr 18, 2021 at 09:06:11PM +0300, Laurent Pinchart wrote:
Hi Tomi and Sakari,

Thank you for the patch.

There's an extra "to" in the subject line.

On Thu, Apr 15, 2021 at 04:04:37PM +0300, Tomi Valkeinen wrote:
From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

Links are validated along the pipeline which is about to start streaming.
Not all the pads in entities that are traversed along that pipeline are
part of the pipeline, however. Skip the link validation for such pads,
and while at there rename "other_pad" to "local_pad" to convey the fact
the route to be checked is internal to the entity.

Both "pad" and "local_pad" are local. I would have kept the "other_pad"

The pad that in the remote entity is not local. The other one could be
called remote_pad though.

I'm not sure what you mean here. Aren't both pad and local_pad pads of a single entity here? If so, I think Laurent's comment makes sense, and other_pad is a better name.

 Tomi



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux