Hi Deb, On 22/04/2021 05:27, Deborah Brouwer wrote: > Update the Set Audio Rate test to include the Audio System source mask. > Add an active sensing test. > Add an invalid operand test. Thank you for this patch series, it's been applied so you can mark this Outreachy contribution as Accepted! I have some follow-up comments for refinements (see my upcoming replies to the corresponding patches), but those can be addressed in new patches. Regards, Hans > > Changes since v3: > * Patch 1: cec-compliance: add Audio System mask to Set Audio Rate > * New patch > > * Patch 2: cec: add active sensing test for Audio Rate Control > * Remove comments indicating basic and rudimentary status of test. > * Add Audio System source mask to active sensing test. > > * Patch 3: cec: add invalid operand test for Audio Rate Control messages > * Replace "parameter" with "operand" in name, commit msg and comment. > * Add Audio System source mask to invalid operand test. > > Changes since v2: > * Patch 1: cec: add active sensing test for Audio Rate Control > * No changes. > > * Patch 2: cec: add invalid parameter test for Audio Rate Control > * Add indent to correct formatting error. > * Change invalid parameter from -1 to 0xa. > * Add check that message has not timed_out. > * Add check that cec_msg_status_is_abort. > * Add break at end of default case statement. > > Changes since v1: > * Patch 1: cec: add active sensing test for Audio Rate Control > * remove or add spaces to conform to kernel coding style. > * add empty line to improve readability. > * add and clarify comments; remove TODO comment. > * change commit subject to refer to "active sensing". > * rename function to audio_rate_ctl_active_sensing. > * rename node state to last_aud_rate_rx_ts. > * make follower warning more specific. > * change control flow in cec-processing to avoid extra indent. > > Deborah Brouwer (3): > cec-compliance: add Audio System mask to Set Audio Rate > cec: add active sensing test for Audio Rate Control messages > cec: add invalid operand test for Audio Rate Control messages > > utils/cec-compliance/cec-test-audio.cpp | 62 +++++++++++++++++++++++-- > utils/cec-follower/cec-follower.cpp | 1 + > utils/cec-follower/cec-follower.h | 1 + > utils/cec-follower/cec-processing.cpp | 50 ++++++++++++++++---- > 4 files changed, 100 insertions(+), 14 deletions(-) > > -- > 2.17.1 >
