On 20/04/2021 19:19, Deepak R Varma wrote: > On Tue, Apr 20, 2021 at 03:24:32PM +0200, Hans Verkuil wrote: >> On 19/04/2021 21:12, Deepak R Varma wrote: >>> Improve multi-line function argument alignment according to the code style >>> guidelines. Resolves checkpatch feedback: "Alignment should match >>> open parenthesis". >>> >>> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx> >> >> WARNING: From:/Signed-off-by: email address mismatch: 'From: Deepak R Varma <mh12gx2825@xxxxxxxxx>' != 'Signed-off-by: Deepak R Varma >> <drv@xxxxxxxxx>' >> >> Which email should I use? Ideally you should post from the same email >> as the Signed-off-by. > > I am really sorry for this. I was trying to set up mutt to handle both > my accounts and guess that led to this issue. I will resubmit the patch > set with the appropriate email match. Will that be okay? It is sufficient to just let me know which email I should use. I can edit it so it shows the correct author email. Regards, Hans > > Thank you, > deepak. > >> >> Regards, >> >> Hans >> >>> --- >>> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- >>> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++-- >>> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++-- >>> 3 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c >>> index 2b71de722ec3..6be3ee1d93a5 100644 >>> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c >>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c >>> @@ -192,8 +192,8 @@ static int __gc0310_buf_reg_array(struct i2c_client *client, >>> } >>> >>> static int __gc0310_write_reg_is_consecutive(struct i2c_client *client, >>> - struct gc0310_write_ctrl *ctrl, >>> - const struct gc0310_reg *next) >>> + struct gc0310_write_ctrl *ctrl, >>> + const struct gc0310_reg *next) >>> { >>> if (ctrl->index == 0) >>> return 1; >>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c >>> index 78147ffb6099..6ba4a8adff7c 100644 >>> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c >>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c >>> @@ -171,8 +171,8 @@ static int __gc2235_buf_reg_array(struct i2c_client *client, >>> } >>> >>> static int __gc2235_write_reg_is_consecutive(struct i2c_client *client, >>> - struct gc2235_write_ctrl *ctrl, >>> - const struct gc2235_reg *next) >>> + struct gc2235_write_ctrl *ctrl, >>> + const struct gc2235_reg *next) >>> { >>> if (ctrl->index == 0) >>> return 1; >>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c >>> index eecefcd734d0..aec7392fd1de 100644 >>> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c >>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c >>> @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client, >>> } >>> >>> static int __ov2722_write_reg_is_consecutive(struct i2c_client *client, >>> - struct ov2722_write_ctrl *ctrl, >>> - const struct ov2722_reg *next) >>> + struct ov2722_write_ctrl *ctrl, >>> + const struct ov2722_reg *next) >>> { >>> if (ctrl->index == 0) >>> return 1; >>> >>