> -----Original Message----- > From: Hans Verkuil [mailto:hverkuil@xxxxxxxxx] > Sent: Sunday, May 09, 2010 7:27 PM > To: linux-media@xxxxxxxxxxxxxxx > Cc: Hiremath, Vaibhav > Subject: [PATCH 0/6] [RFC] tvp514x fixes > > Hi Vaibhav, > > While working on the *_fmt to *_mbus_fmt video op conversion I noticed that > tvp514x is confusing the current select TV standard with the detected TV > standard leading to horrible side-effects where called TRY_FMT can actually > magically change the TV standard. > > I fixed this and I also simplified the format handling in general. Basically > removing the format list table and realizing that since there is only one > supported format, you can just return that format directly. > > This will also make the next step much easier where enum/try/s/g_fmt is > replaced by enum/try/s/g_mbus_fmt. > > However, I have no way of testing this. Can you review this code and let > me know if it is OK? > [Hiremath, Vaibhav] Sorry Hans for delayed response on this, actually today almost whole day I had to spend collecting docs for VISA application and stuff. Thanks for working on this and changing the driver, I will take a look at it (Also I will validate it here at my end) and update you on this. Thanks, Vaibhav > Regards, > > Hans > > Hans Verkuil (6): > tvp514x: do NOT change the std as a side effect > tvp514x: make std_list const > tvp514x: there is only one supported format, so simplify the code > tvp514x: add missing newlines > tvp514x: remove obsolete fmt_list > tvp514x: simplify try/g/s_fmt handling > > drivers/media/video/tvp514x.c | 223 ++++++++------------------------------ > --- > 1 files changed, 40 insertions(+), 183 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
