Hi Hans, On Sunday 09 May 2010 21:29:05 Hans Verkuil wrote: > Few drivers implement VIDIOC_G/S_PRIORITY and those that do often implement > it incorrectly. > > Now that we have a v4l2_fh struct it is easy to add support for priority > handling to the v4l core framework. > > There are three types of drivers: > > 1) Those that use v4l2_fh. There the local priority can be stored in the > v4l2_fh struct. > > 2) Those that do not have an open or release function defined in > v4l2_file_ops. That means that file->private_data will never be filled and > so we can use that to store the local priority in. > > 3) Others. In all other cases we leave it to the driver. Of course, the > goal is to eventually move the 'others' into type 1 or 2. > > This patch series shows how it is done and converts ivtv to rely on the > core framework instead of doing it manually. > > Comments? I don't think this is right. You're moving the priority ioctls support to v4l2_device, while it would make more sense to move it to video_device. If a device can capture two independent video streams simultaneously, your patches would prevent it from working at all. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
