On 13/04/2021 20:21, ascordeiro wrote:
> Em ter, 2021-04-13 às 17:06 +0200, Hans Verkuil escreveu:
>> On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
>>> Remove unused macro functions "to_iss_device()", "to_device()",
>>> and "v4l2_dev_to_iss_device(dev)".
>>
>> 'git grep to_iss_device drivers/staging/omap4iss' gives me lots of
>> hits!
>> Same for to_device. Only v4l2_dev_to_iss_device appears to be unused.
>>
>> Regards,
>>
>> Hans
>>
> This command is really helpful, I didin't know.
> Thank you for the tip.
>
> May I send a v2 removing just v4l2_dev_to_iss_device?
Sure, that's fine.
Regards,
Hans
>
> Thank you in advance,
> Aline
>
>>>
>>> Signed-off-by: Aline Santana Cordeiro <
>>> alinesantanacordeiro@xxxxxxxxx>
>>> ---
>>> drivers/staging/media/omap4iss/iss.h | 8 --------
>>> 1 file changed, 8 deletions(-)
>>>
>>> diff --git a/drivers/staging/media/omap4iss/iss.h
>>> b/drivers/staging/media/omap4iss/iss.h
>>> index b88f952..a354d5f 100644
>>> --- a/drivers/staging/media/omap4iss/iss.h
>>> +++ b/drivers/staging/media/omap4iss/iss.h
>>> @@ -29,11 +29,6 @@
>>>
>>> struct regmap;
>>>
>>> -#define to_iss_device(ptr_module) \
>>> - container_of(ptr_module, struct iss_device, ptr_module)
>>> -#define
>>> to_device(ptr_module) \
>>> - (to_iss_device(ptr_module)->dev)
>>> -
>>> enum iss_mem_resources {
>>> OMAP4_ISS_MEM_TOP,
>>> OMAP4_ISS_MEM_CSI2_A_REGS1,
>>> @@ -119,9 +114,6 @@ struct iss_device {
>>> unsigned int isp_subclk_resources;
>>> };
>>>
>>> -#define v4l2_dev_to_iss_device(dev) \
>>> - container_of(dev, struct iss_device, v4l2_dev)
>>> -
>>> int omap4iss_get_external_info(struct iss_pipeline *pipe,
>>> struct media_link *link);
>>>
>>>
>>
>
>
