Hi, Here's v2, with a small change in the vb2_queue_change_type help text, and with vivid changed to use vb2_queue_change_type. I'm not familiar with vivid, or even the v4l2 features it's using, so please review with care. v4l2-compliance passes, but I'm not sure if I tested all the functionality vivid offers. Tomi Tomi Valkeinen (3): media: videobuf2-v4l2.c: add vb2_queue_change_type() helper media: vivid: remove stream_sliced_vbi_cap field media: vivid: use vb2_queue_change_type .../media/common/videobuf2/videobuf2-v4l2.c | 14 ++++++ drivers/media/test-drivers/vivid/vivid-core.c | 44 ++++++++++++++++++- drivers/media/test-drivers/vivid/vivid-core.h | 1 - .../test-drivers/vivid/vivid-kthread-cap.c | 2 +- .../media/test-drivers/vivid/vivid-vbi-cap.c | 8 +--- include/media/videobuf2-v4l2.h | 15 +++++++ 6 files changed, 74 insertions(+), 10 deletions(-) -- 2.25.1