On 09/04/2021 13:19, Dan Carpenter wrote:
Hello Bryan O'Donoghue,
This is a semi-automatic email about new static checker warnings.
The patch ff2a7013b3e6: "media: venus: hfi,pm,firmware: Convert to
block relative addressing" from Apr 2, 2021, leads to the following
Smatch complaint:
drivers/media/platform/qcom/venus/hfi_venus.c:1100 venus_isr()
warn: variable dereferenced before check 'hdev' (see line 1097)
drivers/media/platform/qcom/venus/hfi_venus.c
1096 u32 status;
1097 void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;
^^^^^^^^^^
1098 void __iomem *wrapper_base = hdev->core->wrapper_base;
^^^^^^^^^^
The patch adds new unchecked dereferences before ...
1099
1100 if (!hdev)
^^^^^
... this check.
1101 return IRQ_NONE;
1102
regards,
dan carpenter
https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg2540720.html
