Em sex, 2021-04-09 às 10:25 +0200, Vaishali Thakkar escreveu: > On Thu, Apr 8, 2021 at 7:41 PM ascordeiro > <alinesantanacordeiro@xxxxxxxxx> wrote: > > > > Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu: > > > Ola Aline, > > Ola Ezequiel, > > > > > Welcome to the kernel community. Hope you enjoy some of this > > > Outreachy adventures. > > Thank you! > > > > > Normally, when you submit a v2, we want to know what changed > > > between the first submission and v2. > > > > > > If you are subscribed to linux-media, you can read some > > > of the series with a vN+1 and look how it's done. Examples: > > > > > > https://www.spinics.net/lists/linux-media/msg190043.html > > > > > > https://www.spinics.net/lists/linux-media/msg189923.html > > > > > > I'm sure your Outreachy mentors can tell you more. > > Thank you for the examples, it won't happen again. > > > > The reason for sending a v2 is that I sent my very first patchset > > yesterday and I sent the cover-letter together, but (I think) I > > wasn't > > supposed to, and as the patches weren't marked as [PATCH 1/2] and > > [PATCH 2/2] in the email - since I commited all the files with the > > same > > message - I tought it was wrong and sent again today. > > > > However, I just realized that I've changed just the subject of the > > e- > > mail, but I would've to change the commit message, right? And then, > > it > > would be a second version, am I right? > > Your next version should be v3 with information about changes since > v1 under --- . If you send it with v2, it'll still be confusing for > people > because then they have to manually find out the difference between > two different patchsets with the same subject line. :) > > You can also check 'Revising your patches' section in the tutorial. Thank you, Vaishali! You made it clear :) I'm going to correct the patchset and send v3. > > Thank you in advance, > > > > > On Thu, 2021-04-08 at 11:07 -0300, Aline Santana Cordeiro wrote: > > > > Aligns line break with the remaining function arguments > > > > to the open parenthesis. Issue found by checkpatch. > > > > > > > > Signed-off-by: Aline Santana Cordeiro < > > > > alinesantanacordeiro@xxxxxxxxx> > > > > --- > > > > drivers/staging/media/hantro/hantro_hw.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/media/hantro/hantro_hw.h > > > > b/drivers/staging/media/hantro/hantro_hw.h > > > > index 34c9e46..a650b9c 100644 > > > > --- a/drivers/staging/media/hantro/hantro_hw.h > > > > +++ b/drivers/staging/media/hantro/hantro_hw.h > > > > @@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width, > > > > unsigned int height) > > > > void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx); > > > > void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx); > > > > void hantro_mpeg2_dec_copy_qtable(u8 *qtable, > > > > - const struct v4l2_ctrl_mpeg2_quantization *ctrl); > > > > + const struct > > > > v4l2_ctrl_mpeg2_quantization *ctrl); > > > > int hantro_mpeg2_dec_init(struct hantro_ctx *ctx); > > > > void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx); > > > > > > > > > > > > > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > > To view this discussion on the web visit > > https://groups.google.com/d/msgid/outreachy-kernel/6bba0e0a5768e902ffec4bda563d4ca810412f84.camel%40gmail.com > > . > > >
