Hi Laurent,
On Mon, Mar 22, 2021 at 03:29:56PM +0200, Laurent Pinchart wrote:
> Hi Edgar,
>
> I've just been notified that I had forgotten about this patch series :-S
> Mea culpa.
>
> On Mon, Jul 08, 2019 at 08:02:25AM +0200, Edgar Thier wrote:
> > These formats are compressed 12-bit raw bayer formats with four different
> > pixel orders. The pixel follow one another without any padding,
>
> s/pixel follow/pixels follow/
>
> > thus are packed in a 'linear' fashion.
> >
> > Signed-off-by: Edgar Thier <info@xxxxxxxxxxxxxx>
> > ---
> > Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 +
> > .../media/uapi/v4l/pixfmt-srggb12lp.rst | 76 +++++++++++++++++++
> > drivers/media/v4l2-core/v4l2-ioctl.c | 4 +
> > include/uapi/linux/videodev2.h | 7 ++
> > 4 files changed, 88 insertions(+)
> > create mode 100644 Documentation/media/uapi/v4l/pixfmt-srggb12lp.rst
> >
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > index 48ab80024835..9efa500c02dc 100644
> > --- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > +++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > @@ -26,5 +26,6 @@ RGB Formats
> > pixfmt-srggb10-ipu3
> > pixfmt-srggb12
> > pixfmt-srggb12p
> > + pixfmt-srggb12lp
>
> I'd move this above srggb12p to order them alphabetically.
>
> > pixfmt-srggb14p
> > pixfmt-srggb16
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb12lp.rst b/Documentation/media/uapi/v4l/pixfmt-srggb12lp.rst
> > new file mode 100644
> > index 000000000000..08d73cfdc42d
> > --- /dev/null
> > +++ b/Documentation/media/uapi/v4l/pixfmt-srggb12lp.rst
> > @@ -0,0 +1,76 @@
> > +.. -*- coding: utf-8; mode: rst -*-
> > +
> > +.. _v4l2-pix-fmt-sbggr12lp:
> > +.. _v4l2-pix-fmt-sgbrg12lp:
> > +.. _v4l2-pix-fmt-sgrbg12lp:
> > +.. _v4l2-pix-fmt-srggb12lp:
> > +
> > +**********************************************************************************************************************************
> > +V4L2_PIX_FMT_SBGGR12LP ('BGCp'), V4L2_PIX_FMT_SGBRG12LP ('GBCp'), V4L2_PIX_FMT_SGRBG12LP ('GRCp'), V4L2_PIX_FMT_SRGGB12LP ('RGCp')
> > +**********************************************************************************************************************************
> > +
> > +12-bit Bayer formats
>
> This should be
>
> 12-bit linear packed Bayer formats
> ----------------------------------
>
> > +
> > +Description
> > +===========
> > +
> > +These packed Bayer formats are used by industrial cameras, often in conjunction
> > +with UsbVision (see https://www.visiononline.org/userAssets/aiaUploads/file/USB3_Vision_Specification_v1-0-1.pdf).
> > +
> > +The formats are equal to the Genicam PFNC Bayer12p formats
> > +(see https://www.emva.org/wp-content/uploads/GenICam_PFNC_2_3.pdf).
> > +
> > +They are raw sRGB / Bayer formats with 12 bits
> > +per sample with 3 bytes for every 2 pixels.
> > +
> > +The format is little endian.
>
> I'd drop this line, as there's no real endianess here, is there ?
>
> With those small changes,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Feel free to add:
Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
--
Kind regards,
Sakari Ailus
