Please specify in the subject line which driver this patch changes. I also would prefer that this is split into two patches, one for each driver. Just saying 'media: usb:' makes it look like you have a media/usb subsystem patch, but that's not the case. Very confusing for code reviewers. Regards, Hans On 27/03/2021 08:42, Wan Jiabing wrote: > struct cx231xx has been declared at 146th line. > struct em28xx has been declared at 219th line. > Remove the duplicate. > > Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx> > --- > drivers/media/usb/cx231xx/cx231xx.h | 2 -- > drivers/media/usb/em28xx/em28xx.h | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/media/usb/cx231xx/cx231xx.h b/drivers/media/usb/cx231xx/cx231xx.h > index b32eab641793..6929e4d97067 100644 > --- a/drivers/media/usb/cx231xx/cx231xx.h > +++ b/drivers/media/usb/cx231xx/cx231xx.h > @@ -425,8 +425,6 @@ struct cx231xx_audio { > u16 end_point_addr; > }; > > -struct cx231xx; > - > /*****************************************************************/ > /* set/get i2c */ > /* 00--1Mb/s, 01-400kb/s, 10--100kb/s, 11--5Mb/s */ > diff --git a/drivers/media/usb/em28xx/em28xx.h b/drivers/media/usb/em28xx/em28xx.h > index 6648e11f1271..43227111d410 100644 > --- a/drivers/media/usb/em28xx/em28xx.h > +++ b/drivers/media/usb/em28xx/em28xx.h > @@ -628,8 +628,6 @@ struct em28xx_audio { > atomic_t stream_started; /* stream should be running if true */ > }; > > -struct em28xx; > - > enum em28xx_i2c_algo_type { > EM28XX_I2C_ALGO_EM28XX = 0, > EM28XX_I2C_ALGO_EM2800, >