On Fri, Apr 2, 2021 at 3:19 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > Lukas, can you share your /etc/fstab ? Also, how long do you stay in > the boot before you try to suspend? OK I cannot reproduce the issue with the modified patch I sent to test_firmware, which if you enable config_enable_resume_test will trigger a request_firmware() on resume, thus trying to mimic the race you note. To test this you can simply use a loopback filesystem for your /lib/firmware and create a btrfs filesystem for it, and then run: echo 1 > /sys/devices/virtual/misc/test_firmware/config_enable_resume_test systemctl suspend Then resume. You should see "resume test" print on dmesg. I keep my /lib/firmware/ empty and still, nothing. Can you provide kernel logs for where you are seeing things get stuck at? Note that I had mentioned the races on suspend/resume do exist for any journaling filesystem, but this typically happens if you are doing ongoing writes. I suppose you are *not* doing writes and your filesystem is idle. As such without kernel logs I cannot be sure what the issue is, but at this point after the initial testing I've done I don't suspect this is a firmware API issue. You might be better off just reposting your patches with the respective Reviewed-by tags and pestering your maintainer. PS. If you want to test this on a guest you bring the guest back up with virsh dompmwakeup. Luis
