Hello Steven, > I can test your TDA10048 patches and add sign-off for merge. Looking > at the list it appears that you have a few nice cleanups. I'll draw > all of these together this weekend and run some tests. Thanks a lot. By the way, I found the read_ber function not fully defined. I guess this subject has already been addressed on this list but cannot pinpoint where in the archives. Did I miss something ? First, *ber is an unsigned integer type, then the bit-error-rate (<=1) has obviously to be made higher than 1. I have decided to multiply the actual ber into 1e8 for two reasons: - 1e-8 offers a good precision and is compatible with what can give the TDA10046/TDA10048 for the VBER - the theoretical max value (1 -> 1e8) fits into the u32 type Naturally, this factor of 1e8 should be defined to be homogeneous for all channel decoders as the read_ber function is exposed. Second, the returned BER is the channel bit-error-rate which is the BER estimation before the Viterbi decoder (for DVB-T). Why this choice ? Thanks in advance for clarifying. -- Guillaume -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
