Hi Hans, Thank you for the patch. On Tue, Mar 23, 2021 at 09:12:47AM +0100, Hans Verkuil wrote: > Add missing documentation for two field. This fixes these kernel-doc > warnings: > > drivers/media/platform/omap3isp/omap3isp.h:107: warning: Function parameter or member 'vp_clk_pol' not described in 'isp_ccp2_cfg' > drivers/media/platform/omap3isp/omap3isp.h:107: warning: Function parameter or member 'lanecfg' not described in 'isp_ccp2_cfg' > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > diff --git a/drivers/media/platform/omap3isp/omap3isp.h b/drivers/media/platform/omap3isp/omap3isp.h > index 214f94c46a9d..4a003c8263ed 100644 > --- a/drivers/media/platform/omap3isp/omap3isp.h > +++ b/drivers/media/platform/omap3isp/omap3isp.h > @@ -95,6 +95,8 @@ struct isp_csiphy_lanes_cfg { > * ISP_CCP2_PHY_DATA_CLOCK - Data/clock physical layer > * ISP_CCP2_PHY_DATA_STROBE - Data/strobe physical layer > * @vpclk_div: Video port output clock control > + * @vp_clk_pol: Video port output clock polarity > + * @lanecfg: CCP2/CSI2 lane configuration > */ > struct isp_ccp2_cfg { > unsigned int strobe_clk_pol:1; -- Regards, Laurent Pinchart