Hi Gregor, On 14/03/2021 22:51, Gregor Jasny wrote: > Hello Hans, > > On 04.03.21 17:25, Gregor Jasny wrote: >> qv4l fails to build with GCC 11: >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984381 >> >> The reason is that min/max are defined as macros here: >> https://git.linuxtv.org/v4l-utils.git/tree/utils/common/v4l2-tpg.patch#n200 >> <https://git.linuxtv.org/v4l-utils.git/tree/utils/common/v4l2-tpg.patch#n200> >> >> should I apply a fix which prefixes the min/max/3 macros with libv4l_? > > Could you please take a look at the patch below and tell me if I should > apply it to v4l-utils master (or of cause, apply it yourself)? > > https://sources.debian.org/patches/v4l-utils/1.20.0-3/fix-gcc-11-ftbfs.diff/ This isn't right: The changes to capture-win-gl.cpp are definitely wrong since this is openGL code, so this should remain as-is. The code from v4l2-tpg.patch can be simplified: the only place min and max is used is in the min3 and max3 defines. So it is enough to rename the min/max defines to tpg_min/max. I've made that change to v4l-utils and pushed it. Please check if this resolves the issue. Regards, Hans
