Hi Hans, On Tue, 2021-03-09 at 09:35 +0100, Hans Verkuil wrote: > The first codec that was supported in V4L2 was the MPEG codec. > As a result of that all codec controls and related data structures > where all prefixed with MPEG. This is confusing and in fact makes > it hard to find the MPEG-specific controls since all controls have > 'MPEG' in their name. > > This patch renames all controls and data structures to use CODEC > instead of MPEG, and adds defines for compatibility at the end. > > Eventually those compatibility defines would come under #ifndef __KERNEL__ > to ensure that the kernel code can't use those anymore, but that can > only be done once the use of the old names has been removed from the > kernel. > > This patch has no functional changes, only renames and the addition > of compatibility defines at the end. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > --- > Would this be acceptable? I really hate the old names, that was a > lack of foresight at my end when I created them :-( > The current names are indeed confusing, doubly so as it is exposed to applications. Getting rid of these, shows that the subsystem is not haunted by historical choices, that don't make sense anymore, so seems a good idea, and worth the trouble IMO. And indeed distinguishing CODEC-specific from MPEG-specific controls will be less painful. > If this rename action is supported, then I can turn this in a proper > patch series that renames the code in the drivers and documentation > as well. Would be great to script the change. Thanks, Ezequiel
