On 11/03/2021 13:20, Ricardo Ribalda wrote: > Fixes v4l2-compliance: > > Control ioctls (Input 0): > fail: v4l2-test-controls.cpp(448): s_ctrl returned an error (22) > test VIDIOC_G/S_CTRL: FAIL > fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an error (22) > test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL -EIO is specifically meant for FW/HW issues. So make clear in this commit log that if an error occurs in the code at that place, then that's because of the device doing something unexpected. Actually, that should be in a comment before the 'return -EIO;'. Regards, Hans > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > --- > drivers/media/usb/uvc/uvc_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index f2f565281e63..5442e9be1c55 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -113,7 +113,7 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit, > case 6: /* Invalid control */ > case 7: /* Invalid Request */ > case 8: /* Invalid value within range */ > - return -EINVAL; > + return -EIO; > default: /* reserved or unknown */ > break; > } >
