On 10/03/2021 22:24, Ricardo Ribalda wrote:
> If there are multiple classes, the ioctl should fail.
It shouldn't matter if there are multiple classes or not, it should
work.
What is the exact error you get with which driver?
Regards,
Hans
>
> Fixes: 0884b19adada ("v4l2-compliance: add test for V4L2_CTRL_WHICH_DEF_VAL")
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> utils/v4l2-compliance/v4l2-test-controls.cpp | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/utils/v4l2-compliance/v4l2-test-controls.cpp b/utils/v4l2-compliance/v4l2-test-controls.cpp
> index 9a68b7e847b0..79982bc15054 100644
> --- a/utils/v4l2-compliance/v4l2-test-controls.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-controls.cpp
> @@ -793,7 +793,10 @@ int testExtendedControls(struct node *node)
> ctrls.which = V4L2_CTRL_WHICH_DEF_VAL;
> fail_on_test(!doioctl(node, VIDIOC_S_EXT_CTRLS, &ctrls));
> fail_on_test(!doioctl(node, VIDIOC_TRY_EXT_CTRLS, &ctrls));
> - fail_on_test(doioctl(node, VIDIOC_G_EXT_CTRLS, &ctrls));
> + if (multiple_classes)
> + fail_on_test(!doioctl(node, VIDIOC_G_EXT_CTRLS, &ctrls));
> + else
> + fail_on_test(doioctl(node, VIDIOC_G_EXT_CTRLS, &ctrls));
> return 0;
> }
>
>
