Hi Rob, On Fri, 2021-03-05 at 16:42 -0600, Rob Herring wrote: > On Thu, Feb 18, 2021 at 11:41:49AM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). > > > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > > --- > > v3->v4: > > * Add 'fsl,sc-resource' property. (Rob) > > > > v2->v3: > > * Drop 'fsl,syscon' property. (Rob) > > * Mention the CSR module controls PXL2DPI. > > > > v1->v2: > > * Use graph schema. (Laurent) > > > > .../display/bridge/fsl,imx8qxp-pxl2dpi.yaml | 108 +++++++++++++++++++++ > > 1 file changed, 108 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml > > new file mode 100644 > > index 00000000..e4e77fa > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml > > @@ -0,0 +1,108 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fbridge%2Ffsl%2Cimx8qxp-pxl2dpi.yaml%23&data=04%7C01%7Cvictor.liu%40nxp.com%7Ca37ec67ba3274bcea5c408d8e027f69b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637505809544037562%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=UN2IQps7q5vK6uNG8fQTn1Klgn0cVyuYnUeqxrjCWHo%3D&reserved=0 > > +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=04%7C01%7Cvictor.liu%40nxp.com%7Ca37ec67ba3274bcea5c408d8e027f69b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637505809544037562%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cvJVL3Fp1hwbjj1jO1YAozKdZATt5DJ78E7vGT%2F25Oc%3D&reserved=0 > > + > > +title: Freescale i.MX8qxp Pixel Link to Display Pixel Interface > > + > > +maintainers: > > + - Liu Ying <victor.liu@xxxxxxx> > > + > > +description: | > > + The Freescale i.MX8qxp Pixel Link to Display Pixel Interface(PXL2DPI) > > + interfaces the pixel link 36-bit data output and the DSI controller’s > > + MIPI-DPI 24-bit data input, and inputs of LVDS Display Bridge(LDB) module > > + used in LVDS mode, to remap the pixel color codings between those modules. > > + This module is purely combinatorial. > > + > > + The i.MX8qxp PXL2DPI is controlled by Control and Status Registers(CSR) module. > > + The CSR module, as a system controller, contains the PXL2DPI's configuration > > + register. > > So this node should be a child of the CSR. Ideally, this schema is also > referenced from the CSR's schema (and if that doesn't exist, it should > be there first). I can add a patch to introduce a schema for the CSR in this series, just prior to this patch. Do you think if that will be fine? Thanks, Liu Ying > > > + > > +properties: > > + compatible: > > + const: fsl,imx8qxp-pxl2dpi > > + > > + fsl,sc-resource: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: The SCU resource ID associated with this PXL2DPI instance. > > + > > + power-domains: > > + maxItems: 1 > > + > > + fsl,companion-pxl2dpi: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: | > > + A phandle which points to companion PXL2DPI which is used by downstream > > + LVDS Display Bridge(LDB) in split mode. > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: The PXL2DPI input port node from pixel link. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: The PXL2DPI output port node to downstream bridge. > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - fsl,sc-resource > > + - power-domains > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/firmware/imx/rsrc.h> > > + pxl2dpi { > > + compatible = "fsl,imx8qxp-pxl2dpi"; > > + fsl,sc-resource = <IMX_SC_R_MIPI_0>; > > + power-domains = <&pd IMX_SC_R_MIPI_0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + > > + mipi_lvds_0_pxl2dpi_dc_pixel_link0: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&dc_pixel_link0_mipi_lvds_0_pxl2dpi>; > > + }; > > + > > + mipi_lvds_0_pxl2dpi_dc_pixel_link1: endpoint@1 { > > + reg = <1>; > > + remote-endpoint = <&dc_pixel_link1_mipi_lvds_0_pxl2dpi>; > > + }; > > + }; > > + > > + port@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <1>; > > + > > + mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch0: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&mipi_lvds_0_ldb_ch0_mipi_lvds_0_pxl2dpi>; > > + }; > > + > > + mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch1: endpoint@1 { > > + reg = <1>; > > + remote-endpoint = <&mipi_lvds_0_ldb_ch1_mipi_lvds_0_pxl2dpi>; > > + }; > > + }; > > + }; > > + }; > > -- > > 2.7.4 > >
