Re: [PATCH 0/6] media: ite-cir driver cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hias,

On Tue, Feb 23, 2021 at 05:13:07PM +0100, Matthias Reichl wrote:
> Hi Sean,
> 
> On Mon, Feb 22, 2021 at 10:43:23AM +0000, Sean Young wrote:
> > This should not be any functional changes, just various cleanups.
> > 
> > Sean Young (6):
> >   media: ite-cir: remove unused fields
> >   media: ite-cir: set parent device
> >   media: ite-cir: use standard logging and reduce noise
> >   media: ite-cir: carrier and duty cycle can be set via ioctl
> >   media: ite-cir: move runtime information into driver data
> >   media: ite-cir: check for receive overflow
> > 
> >  drivers/media/rc/ite-cir.c | 341 +++++++++----------------------------
> >  drivers/media/rc/ite-cir.h |  49 ++----
> >  2 files changed, 91 insertions(+), 299 deletions(-)
> 
> I did a few tests with this series on top of 5.10.17 and so far
> everything looks fine with ITE8713 CIR.

Great, thank you very much!

> I could only test receiving (don't have a transmitter on that PC)
> and also couldn't test the carrier options (I'm using a demodulating
> TSOP receiver here), but your changes look sane to me.

I only have got an eeepc box, with the same limitations. Do you happen to
know what hardware there is for this driver? It would be nice to test this
properly.

This is the only IR driver that can change the RX carrier range, so it's
kinda interesting.

Thanks!

Sean



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux