On 08/02/2021 13:08, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Feb 08, 2021 at 12:32:29PM +0100, Hans Verkuil wrote:
>> Fix this compiler warning:
>>
>> drivers/media/i2c/imx334.c: In function 'imx334_parse_hw_config':
>> include/linux/dev_printk.h:112:2: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
>> | ^~~~~~~~
>> drivers/media/i2c/imx334.c:783:6: note: 'ret' was declared here
>> 783 | int ret;
>> | ^~~
>>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
>> ---
>> drivers/media/i2c/imx334.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
>> index 07e31bc2ef18..ad530f0d338a 100644
>> --- a/drivers/media/i2c/imx334.c
>> +++ b/drivers/media/i2c/imx334.c
>> @@ -790,7 +790,8 @@ static int imx334_parse_hw_config(struct imx334 *imx334)
>> imx334->reset_gpio = devm_gpiod_get_optional(imx334->dev, "reset",
>> GPIOD_OUT_LOW);
>> if (IS_ERR(imx334->reset_gpio)) {
>> - dev_err(imx334->dev, "failed to get reset gpio %d", ret);
>> + dev_err(imx334->dev, "failed to get reset gpio %ld",
>> + PTR_ERR(imx334->reset_gpio));
>> return PTR_ERR(imx334->reset_gpio);
>> }
>>
>
> Thanks for the patch.
>
> Feel free to merge this through your tree if you think you'll have other
> fixes. In that case,
>
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
>
> I can also pick it if you like.
>
Can you pick it up? I have no new PRs planned this week.
Regards,
Hans
