Hi Kieran, On Mon, Feb 08, 2021 at 11:08:45AM +0000, Kieran Bingham wrote: > Hi Sakari, > > On 08/02/2021 10:44, Sakari Ailus wrote: > > Improve syntax used for camera sensor, CSI-2 ReST and V4L2 async syntax > > for better compatibility with newer Sphinx versions and use function > > references where applicable. > > > > Not all internal references still work as kerneldoc doesn't appear to > > support macros the way they are now used by v4l2-async. > > > > Do you mean that with this some references will no longer > highlight/link, where they used to? or that they no longer do, so this > fixes them? Some that should work don't while there's nothing wrong with the references themselves. In particular the async subdev helpers that are now based on macros are affected. This requires some more investigation and quite possibly a kerneldoc change. > > The changes below look consistent and intentional though: > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Thanks! -- Regards, Sakari Ailus
