Em Sat, 6 Feb 2021 11:18:15 +0100 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > >> Yes, driver "version" means nothing, so functionality is the correct way > >> to handle this. > >> > >> Any chance you all can just drop the kernel version stuff and just > >> report a static number that never goes up to allow people to use the > >> correct api for new stuff? Pick a "modern" number, like 5.10 and leave > >> it there for forever. > > > > Good question. I like the idea of keeping it fixed, marking those fields > > as DEPRECATED at the uAPI documentation. > > > > However, at least the v4l2-compliance tool (used for V4L2 > > development) currently requires it: > > > > if (vcap.version >= 0x050900) // Present from 5.9.0 onwards > > node->might_support_cache_hints = true; > > > > Not sure if uname would work there, or if we would need, to use some > > Kconfig symbol to only return the real version on debug Kernels. > > > > Hans, > > > > What do you think? > > It could be replaced by uname, but if we fix the version number to something > >= 5.9 (which we will no doubt do), then there is no need to change anything here. Sure, but needing to check for a so recent Kernel version probably means that we should have an extra capability somewhere to the feature that it is enabled only if Kernel >= 5.9. > But I was wondering if it wouldn't make sense to create a variant of > LINUX_VERSION_CODE that ignored the sublevel and just always leaves that > at 0. In practice, media API changes only happen at new kernel releases and > not in the stable series (there might be rare exceptions to that, but I'm > not aware of that). I guess there were one or two exceptions of uAPI regressions that happened after a new version that were fixed at stable sublevel 1 or 2. > And while we are using capability flags a lot more these days to ensure > userspace can discover what is and what is not available, we never did a full > analysis of that and I feel a bit uncomfortable about fixing the version > number. We don't need a full analysis for past features. If the version gets fixed on, let's say, 6.0.0, if caps.version >= 0x060000, everything supported up to the present date will be there. We'll just need to have an extra care of ensuring that every new feature added upstream will have a way for userspace to check if it is present. > I see more usages of LINUX_VERSION_CODE in the kernel that look like they do > something similar to what the media subsystem does, and that probably also > do not need the SUBLEVEL. Yeah, other subsystems seem to use it as well. > A LINUX_MAJOR_MINOR_CODE define (or whatever you want to call it) would solve > this problem for us. There are ways to minimize this problem on future stable Kernels. My main concern is if we should keep letting applications relying on caps.version. By keeping cap->version = LINUX_VERSION_CODE; (or any variant of that), applications may simply rely on it, instead of properly implementing a functionality probing code. To be clear: my main concern here is not about media development tools, like v4l2-compliance. It is about real applications that could end breaking on backports that won't be properly back-propagating cap->version. Thanks, Mauro
