Re: [PATCH v7 1/2] dt-bindings: media: Add bindings for imx334

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



HI Rob,

On Thu, Feb 04, 2021 at 05:06:04PM -0600, Rob Herring wrote:
> On Thu, Feb 4, 2021 at 10:17 AM Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> >
> > Hi Rob,
> >
> > On Thu, Feb 04, 2021 at 09:20:57AM -0600, Rob Herring wrote:
> > > On Wed, 03 Feb 2021 13:54:40 +0000, Martina Krasteva wrote:
> > > > From: Martina Krasteva <martinax.krasteva@xxxxxxxxx>
> > > >
> > > > - Add dt-bindings documentation for Sony imx334 sensor driver.
> > > > - Add MAINTAINERS entry for Sony imx334 binding documentation.
> > > >
> > > > Signed-off-by: Martina Krasteva <martinax.krasteva@xxxxxxxxx>
> > > > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@xxxxxxxxx>
> > > > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@xxxxxxxxx>
> > > > Acked-by: Paul J. Murphy <paul.j.murphy@xxxxxxxxx>
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > > ---
> > > >  .../devicetree/bindings/media/i2c/sony,imx334.yaml | 90 ++++++++++++++++++++++
> > > >  MAINTAINERS                                        |  8 ++
> > > >  2 files changed, 98 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > Error: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dts:28.17-18 syntax error
> > > FATAL ERROR: Unable to parse input tree
> 
> That's usually a missing header for #defines.
> 
> > > make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dt.yaml] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1370: dt_binding_check] Error 2
> > >
> > > See https://patchwork.ozlabs.org/patch/1435383
> > >
> > > This check can fail if there are any dependencies. The base for a patch
> > > series is generally the most recent rc1.
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> > >
> > > pip3 install dtschema --upgrade
> > >
> > > Please check and re-submit.
> >
> > Thanks for reporting this. The example was apparently missing the
> > assigned-clock-parents property. I'll squash the following change to the
> > patch:
> 
> Doubtful. That would be a more specific schema error.

Well, I guess the parsing didn't get quite there. There's a missing
semicolon a few lines above it.

> 
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > index 3145e94d043e7..4217fbea0735a 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > @@ -76,6 +76,7 @@ examples:
> >              clocks = <&imx334_clk>

				       ^

> >
> >              assigned-clocks = <&imx334_clk>;
> > +            assigned-clock-parents = <&imx334_clk_parent>;
> >              assigned-clock-rates = <24000000>;
> >
> >              port {
> >

-- 
Kind regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux