Hi Hans, Thank you for the patch. On Mon, Feb 01, 2021 at 09:40:56AM +0100, Hans Verkuil wrote: > The use of strncpy is discouraged, use strscpy instead. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Please feel free to pick this patch for your fixes pull request as I have no other pending UVC patches. > --- > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 1abc122a0977..30ef2a3110f7 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -1553,7 +1553,7 @@ static int uvc_gpio_parse(struct uvc_device *dev) > unit->gpio.bmControls[0] = 1; > unit->get_cur = uvc_gpio_get_cur; > unit->get_info = uvc_gpio_get_info; > - strncpy(unit->name, "GPIO", sizeof(unit->name) - 1); > + strscpy(unit->name, "GPIO", sizeof(unit->name)); > > list_add_tail(&unit->list, &dev->entities); > -- Regards, Laurent Pinchart
