Hi Martina, On Mon, Feb 01, 2021 at 05:24:44PM +0000, Martina Krasteva wrote: > From: Martina Krasteva <martinax.krasteva@xxxxxxxxx> > > - Add dt-bindings documentation for Sony imx334 sensor driver. > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > Signed-off-by: Martina Krasteva <martinax.krasteva@xxxxxxxxx> > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@xxxxxxxxx> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@xxxxxxxxx> > Acked-by: Paul J. Murphy <paul.j.murphy@xxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 77 ++++++++++++++++++++++ > MAINTAINERS | 8 +++ > 2 files changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > new file mode 100644 > index 000000000000..e6b4f41f3232 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 Intel Corporation > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/sony,imx334.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX334 Sensor > + > +maintainers: > + - Paul J. Murphy <paul.j.murphy@xxxxxxxxx> > + - Daniele Alessandrelli <daniele.alessandrelli@xxxxxxxxx> > + > +description: > + IMX334 sensor is a Sony CMOS active pixel digital image sensor with an active > + array size of 3864H x 2202V. It is programmable through I2C interface. The > + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is > + sent through MIPI CSI-2. > + > +properties: > + compatible: > + const: sony,imx334 > + reg: > + description: I2C address > + maxItems: 1 Could you also add the clock properties such as in here: <URL:https://git.linuxtv.org/sailus/media_tree.git/tree/Documentation/devicetree/bindings/media/i2c/imx258.yaml> > + > + port: > + type: object > + additionalProperties: false > + $ref: /schemas/graph.yaml#/properties/port > + > + properties: > + endpoint: > + type: object > + properties: > + data-lanes: > + $ref: ../video-interfaces.yaml#/properties/data-lanes > + link-frequencies: > + $ref: ../video-interfaces.yaml#/properties/link-frequencies > + description: > + Allowed data bus frequencies are 891000000, 594000000 and > + 455500000 Hz. These frequencies are those supported by the driver, aren't they, not those supported by the sensor (of which many support virtually almost the entire range from some 100 MHz to 1 GHz, depending on the external clock frequency)? If so, please drop the description from link-frequencies, or adjust it to what the sensor actually supports. > + > + required: > + - data-lanes > + - link-frequencies > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - port > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@1a { > + compatible = "sony,imx334"; > + reg = <0x1a>; > + > + port { > + imx334: endpoint { > + remote-endpoint = <&cam>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <891000000>; > + }; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 3353de0c4bc8..2ab75519938a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16589,6 +16589,14 @@ S: Maintained > T: git git://linuxtv.org/media_tree.git > F: drivers/media/i2c/imx319.c > > +SONY IMX334 SENSOR DRIVER > +M: Paul J. Murphy <paul.j.murphy@xxxxxxxxx> > +M: Daniele Alessandrelli <daniele.alessandrelli@xxxxxxxxx> > +L: linux-media@xxxxxxxxxxxxxxx > +S: Maintained > +T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > + > SONY IMX355 SENSOR DRIVER > M: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> > L: linux-media@xxxxxxxxxxxxxxx -- Kind regards, Sakari Ailus
