RE: [PATCH-V7] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vaibhav,

> -----Original Message-----
> From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Hiremath, Vaibhav
> Sent: Wednesday, April 07, 2010 5:01 AM
> To: linux-media@xxxxxxxxxxxxxxx
> Cc: mchehab@xxxxxxxxxx; Karicheri, Muralidharan; hverkuil@xxxxxxxxx;
> Hiremath, Vaibhav
> Subject: [PATCH-V7] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on
> top of DSS2
> 
> From: Vaibhav Hiremath <hvaibhav@xxxxxx>
> 
> Features Supported -
> 	1. Provides V4L2 user interface for the video pipelines of DSS
> 	2. Basic streaming working on LCD, DVI and TV.
> 	3. Works on latest DSS2 library from Tomi
> 	4. Support for various pixel formats like YUV, UYVY, RGB32, RGB24,
> 	   RGB565
> 	5. Supports Alpha blending.
> 	6. Supports Color keying both source and destination.
> 	7. Supports rotation.
> 	8. Supports cropping.
> 	9. Supports Background color setting.
> 	10. Allocated buffers to only needed size
> 

This patch is broken in latest kernel. There are 2 main problems:

1. ARCH_OMAP24XX and ARCH_OMAP34XX doesn't exist anymore in latest kernel.

Tony has left only ARCH_OMAP2420, ARCH_OMAP2430 and ARCH_OMAP3430. So, I did the change represented in patch #0001.

2. It doesn't compile.

See attached log.

I was able to partially fix some problems:

drivers/media/video/omap/omap_vout.c: In function 'vidioc_reqbufs':
drivers/media/video/omap/omap_vout.c:1841: error: implicit declaration of function 'kfree'
drivers/media/video/omap/omap_vout.c: In function 'omap_vout_create_video_devices':
drivers/media/video/omap/omap_vout.c:2375: error: implicit declaration of function 'kmalloc'
...
drivers/media/video/omap/omap_vout.c: In function 'omap_vout_probe':
drivers/media/video/omap/omap_vout.c:2514: error: implicit declaration of function 'kzalloc'
drivers/media/video/omap/omap_vout.c:2514: warning: assignment makes pointer from integer without a cast

With the attached patch #0002. But still the other problems are related to latest DSS2 framework changes.

Can you please take a look at those?

Regards,
Sergio

> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> ---
>  drivers/media/video/Kconfig             |    2 +
>  drivers/media/video/Makefile            |    2 +
>  drivers/media/video/omap/Kconfig        |   11 +
>  drivers/media/video/omap/Makefile       |    7 +
>  drivers/media/video/omap/omap_vout.c    | 2644
> +++++++++++++++++++++++++++++++
>  drivers/media/video/omap/omap_voutdef.h |  147 ++
>  drivers/media/video/omap/omap_voutlib.c |  293 ++++
>  drivers/media/video/omap/omap_voutlib.h |   34 +
>  8 files changed, 3140 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/media/video/omap/Kconfig
>  create mode 100644 drivers/media/video/omap/Makefile
>  create mode 100644 drivers/media/video/omap/omap_vout.c
>  create mode 100644 drivers/media/video/omap/omap_voutdef.h
>  create mode 100644 drivers/media/video/omap/omap_voutlib.c
>  create mode 100644 drivers/media/video/omap/omap_voutlib.h
> 

<snip>
x0091359@dtx0091359-ubuntu-1:~/omapzoom/linux-omap-camera$ make ARCH=arm -j3 uImage >/dev/null
drivers/media/video/omap/omap_vout.c: In function 'vidioc_reqbufs':
drivers/media/video/omap/omap_vout.c:1841: error: implicit declaration of function 'kfree'
drivers/media/video/omap/omap_vout.c: In function 'omap_vout_create_video_devices':
drivers/media/video/omap/omap_vout.c:2375: error: implicit declaration of function 'kmalloc'
drivers/media/video/omap/omap_vout.c:2375: warning: assignment makes pointer from integer without a cast
drivers/media/video/omap/omap_vout.c: In function 'omap_vout_remove':
drivers/media/video/omap/omap_vout.c:2493: error: 'struct omap_dss_device' has no member named 'disable'
drivers/media/video/omap/omap_vout.c: In function 'omap_vout_probe':
drivers/media/video/omap/omap_vout.c:2514: error: implicit declaration of function 'kzalloc'
drivers/media/video/omap/omap_vout.c:2514: warning: assignment makes pointer from integer without a cast
drivers/media/video/omap/omap_vout.c:2550: error: 'struct omap_dss_device' has no member named 'enable'
drivers/media/video/omap/omap_vout.c:2570: error: 'struct omap_dss_device' has no member named 'enable_te'
drivers/media/video/omap/omap_vout.c:2571: error: 'struct omap_dss_device' has no member named 'enable_te'
drivers/media/video/omap/omap_vout.c:2572: error: 'struct omap_dss_device' has no member named 'set_update_mode'
drivers/media/video/omap/omap_vout.c:2573: error: 'struct omap_dss_device' has no member named 'set_update_mode'
drivers/media/video/omap/omap_vout.c:2577: error: 'struct omap_dss_device' has no member named 'set_update_mode'
drivers/media/video/omap/omap_vout.c:2578: error: 'struct omap_dss_device' has no member named 'set_update_mode'
drivers/media/video/omap/omap_vout.c:2597: error: 'struct omap_dss_device' has no member named 'update'
drivers/media/video/omap/omap_vout.c:2598: error: 'struct omap_dss_device' has no member named 'update'
drivers/media/video/omap/omap_vout.c:2614: error: 'struct omap_dss_device' has no member named 'disable'
make[4]: *** [drivers/media/video/omap/omap_vout.o] Error 1
make[3]: *** [drivers/media/video/omap] Error 2
make[2]: *** [drivers/media/video] Error 2
make[1]: *** [drivers/media] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes.  Stop.

Attachment: 0002-omap_vout-Include-linux-slab.h-explicitly.patch
Description: 0002-omap_vout-Include-linux-slab.h-explicitly.patch

Attachment: 0001-OMAP2-3-V4L2-Remove-deprecated-ARCH_OMAP34XX-and-ARC.patch
Description: 0001-OMAP2-3-V4L2-Remove-deprecated-ARCH_OMAP34XX-and-ARC.patch


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux