Hi Dafna, On Thu, Jan 21, 2021 at 01:48:58PM +0100, Dafna Hirschfeld wrote: > > > Am 20.01.21 um 22:32 schrieb Sakari Ailus: > > Hi Dafna, > > > > Thanks for the update. > > > > On Wed, Jan 20, 2021 at 05:44:42PM +0100, Dafna Hirschfeld wrote: > > > Each entry in the array is a 20 bits value composed of 16 > > > bits unsigned integer and 4 bits fractional part. So the > > > type should change to __u32. > > > In addition add a documentation of how the measurements > > > are done. > > > > The commit message lines wrap at 74, under 60 is not much. > > > > > > > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> > > > > Should there be a Fixes: line? The patch is changing UAPI... > > > > The file has been recently introduced. Should it go to fixes or to a stable > > kernel, too? > > The file was in the staging directory and will be first destaged in the coming 5.11, > so I don't think this is necessary. You still probably want to avoid making the uAPI change after 5.11, so the fixes branch would be the right target I presume. -- Sakari Ailus
