[lwn:docs-next 23/23] fs/super.c:1728: warning: expecting prototype for thaw_super(). Prototype was for thaw_super_locked() instead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://git.lwn.net/linux-2.6 docs-next
head:   52042e2db45290f6a512d525518488b7bf143531
commit: 52042e2db45290f6a512d525518488b7bf143531 [23/23] scripts: kernel-doc: validate kernel-doc markup with the actual names
config: sparc-randconfig-m031-20210118 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add lwn git://git.lwn.net/linux-2.6
        git fetch --no-tags lwn docs-next
        git checkout 52042e2db45290f6a512d525518488b7bf143531
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> fs/super.c:1728: warning: expecting prototype for thaw_super(). Prototype was for thaw_super_locked() instead
--
>> fs/seq_file.c:672: warning: wrong kernel-doc identifier on line:
    * A helper routine for putting decimal numbers without rich format of printf().
>> fs/seq_file.c:1056: warning: expecting prototype for seq_hlist_start_precpu(). Prototype was for seq_hlist_start_percpu() instead
--
>> fs/dcache.c:477: warning: expecting prototype for d_drop(). Prototype was for ___d_drop() instead
>> fs/dcache.c:1014: warning: expecting prototype for d_find_alias(). Prototype was for __d_find_alias() instead
--
>> fs/inode.c:1516: warning: expecting prototype for find_inode_by_rcu(). Prototype was for find_inode_by_ino_rcu() instead
>> fs/inode.c:1789: warning: expecting prototype for touch_atime(). Prototype was for atime_needs_update() instead
--
>> drivers/parport/share.c:280: warning: expecting prototype for parport_register_driver(). Prototype was for __parport_register_driver() instead
--
>> drivers/reset/core.c:888: warning: expecting prototype for device_reset(). Prototype was for __device_reset() instead
--
>> drivers/usb/cdns3/core.c:323: warning: expecting prototype for cdsn3_role_get(). Prototype was for cdns3_role_get() instead
--
>> drivers/usb/cdns3/ep0.c:690: warning: expecting prototype for cdns3_gadget_ep0_queue Transfer data on endpoint zero(). Prototype was for cdns3_gadget_ep0_queue() instead
>> drivers/usb/cdns3/ep0.c:781: warning: expecting prototype for cdns3_gadget_ep_set_wedge Set wedge on selected endpoint(). Prototype was for cdns3_gadget_ep_set_wedge() instead
>> drivers/usb/cdns3/ep0.c:876: warning: expecting prototype for cdns3_init_ep0 Initializes software endpoint 0 of gadget(). Prototype was for cdns3_init_ep0() instead
--
>> drivers/usb/cdns3/gadget.c:162: warning: expecting prototype for select_ep(). Prototype was for cdns3_select_ep() instead
>> drivers/usb/cdns3/gadget.c:509: warning: expecting prototype for cdns3_wa2_descmiss_copy_data copy data from internal requests to(). Prototype was for cdns3_wa2_descmiss_copy_data() instead
>> drivers/usb/cdns3/gadget.c:2029: warning: expecting prototype for cdns3_ep_config Configure hardware endpoint(). Prototype was for cdns3_ep_config() instead
>> drivers/usb/cdns3/gadget.c:2233: warning: expecting prototype for cdns3_gadget_ep_alloc_request Allocates request(). Prototype was for cdns3_gadget_ep_alloc_request() instead
>> drivers/usb/cdns3/gadget.c:2254: warning: expecting prototype for cdns3_gadget_ep_free_request Free memory occupied by request(). Prototype was for cdns3_gadget_ep_free_request() instead
>> drivers/usb/cdns3/gadget.c:2273: warning: expecting prototype for cdns3_gadget_ep_enable Enable endpoint(). Prototype was for cdns3_gadget_ep_enable() instead
>> drivers/usb/cdns3/gadget.c:2406: warning: expecting prototype for cdns3_gadget_ep_disable Disable endpoint(). Prototype was for cdns3_gadget_ep_disable() instead
>> drivers/usb/cdns3/gadget.c:2500: warning: expecting prototype for cdns3_gadget_ep_queue Transfer data on endpoint(). Prototype was for __cdns3_gadget_ep_queue() instead
>> drivers/usb/cdns3/gadget.c:2598: warning: expecting prototype for cdns3_gadget_ep_dequeue Remove request from transfer queue(). Prototype was for cdns3_gadget_ep_dequeue() instead
>> drivers/usb/cdns3/gadget.c:2662: warning: expecting prototype for __cdns3_gadget_ep_set_halt Sets stall on selected endpoint(). Prototype was for __cdns3_gadget_ep_set_halt() instead
>> drivers/usb/cdns3/gadget.c:2683: warning: expecting prototype for __cdns3_gadget_ep_clear_halt Clears stall on selected endpoint(). Prototype was for __cdns3_gadget_ep_clear_halt() instead
>> drivers/usb/cdns3/gadget.c:2730: warning: expecting prototype for clears stall on selected endpoint(). Prototype was for cdns3_gadget_ep_set_halt() instead
>> drivers/usb/cdns3/gadget.c:2775: warning: expecting prototype for cdns3_gadget_get_frame Returns number of actual ITP frame(). Prototype was for cdns3_gadget_get_frame() instead
>> drivers/usb/cdns3/gadget.c:2886: warning: expecting prototype for cdns3_gadget_udc_start Gadget start(). Prototype was for cdns3_gadget_udc_start() instead
>> drivers/usb/cdns3/gadget.c:2930: warning: expecting prototype for cdns3_gadget_udc_stop Stops gadget(). Prototype was for cdns3_gadget_udc_stop() instead
>> drivers/usb/cdns3/gadget.c:2993: warning: expecting prototype for cdns3_init_eps Initializes software endpoints of gadget(). Prototype was for cdns3_init_eps() instead
--
>> lib/crc7.c:66: warning: expecting prototype for crc7(). Prototype was for crc7_be() instead
--
>> crypto/asymmetric_keys/pkcs7_trust.c:20: warning: wrong kernel-doc identifier on line:
    * Check the trust on one PKCS#7 SignedInfo block.
..


vim +1728 fs/super.c

18e9e5104fcd9a97 Josef Bacik   2010-03-23  1720  
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1721  /**
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1722   * thaw_super -- unlock filesystem
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1723   * @sb: the super to thaw
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1724   *
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1725   * Unlocks the filesystem and marks it writeable again after freeze_super().
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1726   */
08fdc8a0138afaf3 Mateusz Guzik 2017-10-03  1727  static int thaw_super_locked(struct super_block *sb)
18e9e5104fcd9a97 Josef Bacik   2010-03-23 @1728  {
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1729  	int error;
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1730  
89f39af129382a40 Oleg Nesterov 2016-09-26  1731  	if (sb->s_writers.frozen != SB_FREEZE_COMPLETE) {
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1732  		up_write(&sb->s_umount);
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1733  		return -EINVAL;
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1734  	}
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1735  
bc98a42c1f7d0f88 David Howells 2017-07-17  1736  	if (sb_rdonly(sb)) {
8129ed29644bf56e Oleg Nesterov 2015-08-11  1737  		sb->s_writers.frozen = SB_UNFROZEN;
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1738  		goto out;
8129ed29644bf56e Oleg Nesterov 2015-08-11  1739  	}
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1740  
f1a9622037cd3704 Oleg Nesterov 2016-09-26  1741  	lockdep_sb_freeze_acquire(sb);
f1a9622037cd3704 Oleg Nesterov 2016-09-26  1742  
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1743  	if (sb->s_op->unfreeze_fs) {
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1744  		error = sb->s_op->unfreeze_fs(sb);
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1745  		if (error) {
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1746  			printk(KERN_ERR
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1747  				"VFS:Filesystem thaw failed\n");
f1a9622037cd3704 Oleg Nesterov 2016-09-26  1748  			lockdep_sb_freeze_release(sb);
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1749  			up_write(&sb->s_umount);
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1750  			return error;
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1751  		}
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1752  	}
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1753  
5accdf82ba25cace Jan Kara      2012-06-12  1754  	sb->s_writers.frozen = SB_UNFROZEN;
8129ed29644bf56e Oleg Nesterov 2015-08-11  1755  	sb_freeze_unlock(sb);
8129ed29644bf56e Oleg Nesterov 2015-08-11  1756  out:
5accdf82ba25cace Jan Kara      2012-06-12  1757  	wake_up(&sb->s_writers.wait_unfrozen);
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1758  	deactivate_locked_super(sb);
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1759  	return 0;
18e9e5104fcd9a97 Josef Bacik   2010-03-23  1760  }
08fdc8a0138afaf3 Mateusz Guzik 2017-10-03  1761  

:::::: The code at line 1728 was first introduced by commit
:::::: 18e9e5104fcd9a973ffe3eed3816c87f2a1b6cd2 Introduce freeze_super and thaw_super for the fsfreeze ioctl

:::::: TO: Josef Bacik <josef@xxxxxxxxxx>
:::::: CC: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux