On 18/01/2021 12:04, Heiko Stuebner wrote: > This NEEDs to go into 5.11 while we can still adapt the uapi > during its RC-cycle. > > > When looking into supporting the rkisp1 of the px30 I noticed that > some fields got bigger in the uapi, caused by bigger number of samples > for example for histograms or gamma values. > > The rkisp1 was destaged with 5.11-rc1 so we have still time during > the 5.11 cycle to fix that without big hassles. > > This was discussed previously in a mail [0] and a rfc series [1] > and this two-part series now splits out the important parts that > really should become part of a 5.11-rc and thus the final 5.11. Nice! If there are no more comments, then I plan a PR for 5.11 on Wednesday. Regards, Hans > > changes since v5: > - move grid reduction for V10 to separate patch (Hans) > - fix commit message (histogram size 28 -> 25) in patch4 (Hans) > > changes since v4: > - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) > - start RKISP_Vxx enum with 10 for RKISP_V10 to make output > easier and also allow userspace to differentiate between old (= 0) > and newer driver variants (Dafna, Laurent) > > changes since v3: > - add patch fixing the original histogram size comment > - make comments in uapi more verbose (Hans) > - fix wording in admin guide (Hans) > - document version <-> soc in uapi as well (easier for people) (Dafna) > > changes since v2: > - actually zero the correct sizes for u16 values (hist-bins) > (kernel-test-robot) > > changes since v1: > - drop duplicate isp_ver storage, hw_revision is enough (Dafna) > - document multiple maximum sizes in uapi (Hans) > - document usage of hw_revision field (Hans) > - zero fields transmitted to userspace before adding data (Hans) > - use _V10 field sizes when filling fields, as there is only v10 for now > > changes since rfc: > - move rkisp1_version enum into uapo > - show version in media-api hw_revision > - introduce constants for versions and make max use the biggest > > > Heiko Stuebner (4): > media: rockchip: rkisp1: fix comment about number of histogram > sub-windows > media: rockchip: rkisp1: reduce number of histogram grid elements in > uapi > media: rockchip: rkisp1: carry ip version information > media: rockchip: rkisp1: extend uapi array sizes > > Documentation/admin-guide/media/rkisp1.rst | 16 ++++ > .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++--- > .../platform/rockchip/rkisp1/rkisp1-params.c | 2 +- > .../platform/rockchip/rkisp1/rkisp1-stats.c | 12 ++- > include/uapi/linux/rkisp1-config.h | 75 +++++++++++++++++-- > 5 files changed, 106 insertions(+), 20 deletions(-) >
