On Fri, 2021-01-15 at 17:05 +0200, Sakari Ailus wrote: > On Fri, Jan 15, 2021 at 11:08:21AM -0300, Ezequiel Garcia wrote: > > On Fri, 2021-01-15 at 01:36 +0200, Sakari Ailus wrote: > > > Hi Ezequiel, > > > > > > On Fri, Jan 08, 2021 at 02:17:28PM -0300, Ezequiel Garcia wrote: > > > > There is currently little to no information available > > > > about the reasons why a v4l2-async device hasn't > > > > probed completely. > > > > > > > > Inspired by the "devices_deferred" debugfs file, > > > > add a file to list information about the subdevices > > > > that are on waiting lists, for each notifier. > > > > > > > > This is useful to debug v4l2-async subdevices > > > > and notifiers, for instance when doing device bring-up. > > > > > > > > For instance, a typical output would be: > > > > > > > > $ cat /sys/kernel/debug/video4linux/pending_async_subdevices > > > > ipu1_csi1: > > > > [fwnode] dev=20e0000.iomuxc-gpr:ipu1_csi1_mux, node=/soc/bus@2000000/iomuxc-gpr@20e0000/ipu1_csi1_mux > > > > ipu1_csi0: > > > > [fwnode] dev=20e0000.iomuxc-gpr:ipu1_csi0_mux, node=/soc/bus@2000000/iomuxc-gpr@20e0000/ipu1_csi0_mux > > > > imx6-mipi-csi2: > > > > [fwnode] dev=1-003c, node=/soc/bus@2100000/i2c@21a4000/camera@3c > > > > imx-media: > > > > > > > > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > -- > > > > v3: > > > > * Drop MATCH_CUSTOM > > > > * Use the actual fwnode, to print the real full path. endpoint name. > > > > * Fix refcounted handle leak. > > > > v2: > > > > * Print fwnode path, as suggested by Sakari. > > > > * Print the subdevices under their corresponding notifier. > > > > * Rename the file as suggested by Laurent. > > > > > > The patch itself seems fine. But lease put such notes below the '---' line > > > below going forward. What's above it will be part of the commit message. > > > > > > > Oops, sorry for the typo. > > > > I have a v4 for this one, dropping MATCH_DEVNAME too. > > Could you remove it as a separate patch? It's unrelated to debugging. > Yes, but still we won't be printing MATCH_DEVNAME types so this patch needs a v4 dropping that. I think it's worth it as it simplifies the patch a bit. Thanks, Ezequiel
