Hi Ezequiel, On Thu, Jan 14, 2021 at 10:36:54AM -0300, Ezequiel Garcia wrote: > On Thu, 2021-01-14 at 04:14 +0200, Laurent Pinchart wrote: > > On Tue, Jan 12, 2021 at 10:23:37AM -0300, Ezequiel Garcia wrote: > > > The v4l2_async_notifier_cleanup documentation mentions > > > v4l2_fwnode_reference_parse_sensor_common, which doesn't exist. > > > Drop it. > > > > The function is actually called > > v4l2_async_notifier_parse_fwnode_sensor_common(). It was introduced in > > commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for > > parsing common external refs") with an incorrect name in the > > documentation. Commit b064945517ee ("media: fix kernel-doc markups") > > fixed the kerneldoc header for the function, but forgot to address this > > location. > > OK, I'll fix the commit description. I think it's more than the commit description, instead of dropping the reference to v4l2_fwnode_reference_parse_sensor_common(), it should be replaced with a reference to v4l2_async_notifier_parse_fwnode_sensor_common(). -- Regards, Laurent Pinchart