Hi Laurent, On Tue, 2021-01-05 at 17:28 +0200, Laurent Pinchart wrote: > When the subdevice connected to the capture device has a single possible > sink, there's no point in making the link mutable. Support creating > immutable links. > Does this apply to csi2_notify_bound as welll that is, is there any point in making the sensor link mutable? > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/staging/media/imx/imx-ic-prpencvf.c | 2 +- > drivers/staging/media/imx/imx-media-capture.c | 7 +++++-- > drivers/staging/media/imx/imx-media-csi.c | 2 +- > drivers/staging/media/imx/imx-media.h | 3 ++- > drivers/staging/media/imx/imx7-media-csi.c | 2 +- > 5 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c > index 88d69425e1b3..6c9c75ffb30c 100644 > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c > @@ -1269,7 +1269,7 @@ static int prp_registered(struct v4l2_subdev *sd) > if (IS_ERR(priv->vdev)) > return PTR_ERR(priv->vdev); > > - ret = imx_media_capture_device_register(priv->vdev); > + ret = imx_media_capture_device_register(priv->vdev, false); Maybe it's just me, but I dislike this boolean parameter pattern, as opposed to passing the flags directly, or some other MUTABLE/IMMUTABLE enum value. Cheers, Ezequiel
