Hi Philipp, On Thu, Jan 7, 2021 at 7:53 AM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > But I don't quite understand why G/S/TRY_FMT should not respect the > connected subdev source pad's active format. Should MC-centric devices > allow to set non-working configurations and only error out on stream > start? Is this documented? > > The current "legacy" vb2_ops check the subdev in ENUM_FRAMESIZES and > ENUM_FRAMEINTERVALS, and in TRY_FMT/S_FMT to determine format and > possible interlacing options. If the MC-centric ops just drop that, > there is no way to determine which interlacing combinations are actually > supported. You make a good point and it is aligned with what I am seeing here too. When I tested this series, I noticed a regression on imx6ul-evk capture and doing a bisect it points to: media: imx: imx7-media-csi: Disable legacy video node API Reverting it back to using the legacy API fixed things for me. When the MC-centric API is used the camera dimensions reported by Gstreamer are no longer correct. Regards, Fabio Estevam
