On Tue, 2021-01-05 at 17:18 +0100, Petr Cvek wrote: > > diff --git a/drivers/media/i2c/ov9640.h b/drivers/media/i2c/ov9640.h > > index a8ed6992c1a8..a1f9150b2050 100644 > > --- a/drivers/media/i2c/ov9640.h > > +++ b/drivers/media/i2c/ov9640.h > > @@ -180,6 +180,8 @@ enum { > > }; > > #define H_SXGA 960 > > > > +struct clk; > > + > > Seems to be unnecessary as struct clk will be included from ov9640.c (the same way struct v4l2_clk was). > > The rest seems fine by me. > Hm, I'm now wondering why I added that. Guess it can be dropped, yes. Thanks, Ezequiel