Re: [RFT][PATCH v1] media: zr364xx: Fix memory leak in ->probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 05, 2021 at 05:00:45PM +0300, Dan Carpenter wrote:
> On Wed, Dec 30, 2020 at 11:19:18PM +0200, Andy Shevchenko wrote:
> > When ->probe() fails in some cases it may not free resources.
> > Replace few separated calls by v4l2_device_put() to clean up
> > everything.
> > 
> 
> The clean up everything style of error handling is always buggy.
> 
> For example, in this case, all the early error paths will now crash
> instead of leaking.  The __videobuf_free() function will Oops when it
> dereferences "q->int_ops->magic".
> 
> 	MAGIC_CHECK(q->int_ops->magic, MAGIC_QTYPE_OPS);
> 
> The "q->int_ops" pointer is set in videobuf_queue_vmalloc_init().  There
> are probably other bugs as well.  It's almost impossible to audit this
> style of error handling either for completeness or for crashyness.

Feel free to submit better fix, thanks!

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux