On 04/21/10 09:58, Andreas Oberritter wrote: > Hello Mauro, > > Mauro Carvalho Chehab wrote: >> Subject: V4L/DVB: Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices >> Author: Klaus Schmidinger <Klaus.Schmidinger@xxxxxxx> >> Date: Sun Apr 11 06:12:52 2010 -0300 > > I wonder why this patch was applied without any modification. It seems > like, as Manu pointed out, the flag should really indicate support for > Turbo-FEC modes rather than just 8PSK (which is already a subset of > FE_CAN_2G_MODULATION). > > Btw., there is also no FE_CAN_APSK_16, FE_CAN_APSK_32 or FE_CAN_DQPSK. > > Also, I'm unsure how to instruct a driver whether to choose Turbo-FEC > mode or not in case it supports both DVB-S2 and what's used in the US. > > Third, it was stated that cx24116's support for Turbo-FEC was untested > and probably unsupported. > > So I'd vote for reverting this patch until these issues are cleared. > > If my assumptions above are correct, my proposal is to rename the flag > to FE_CAN_TURBO_FEC (as Manu proposed earlier) and remove it from > cx24116.c. That's what I was intending to do - time permitting ;-) I was also surprised that the patch got applied, since I was in the middle of discussing this with Manu... Klaus -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
