On Wed, Mar 24, 2010 at 02:17:38PM +0100, Bjørn Mork wrote: > Never call dvb_frontend_detach if we failed to attach a frontend. This fixes > the following oops: > > [ 8.172997] DVB: registering new adapter (TT-Budget S2-1600 PCI) > [ 8.209018] adapter has MAC addr = 00:d0:5c:cc:a7:29 > [ 8.328665] Intel ICH 0000:00:1f.5: PCI INT B -> GSI 17 (level, low) -> IRQ 17 > [ 8.328753] Intel ICH 0000:00:1f.5: setting latency timer to 64 > [ 8.562047] DVB: Unable to find symbol stv090x_attach() > [ 8.562117] BUG: unable to handle kernel NULL pointer dereference at 000000ac > [ 8.562239] IP: [<e08b04a3>] dvb_frontend_detach+0x4/0x67 [dvb_core] > > Ref http://bugs.debian.org/575207 > > Also clean up if we are unable to register the tuner and LNB drivers > > Signed-off-by: Bjørn Mork <bjorn@xxxxxxx> > Cc: stable@xxxxxxxxxx > Reported-by: Fladischer Michael <FladischerMichael@xxxxxxxx> > --- > Oliver Endriss <o.endriss@xxxxxx> writes: > > > Could you please extend your patch in a way > > that it will also catch, if > > - dvb_attach(stv6110x_attach,...) > > - dvb_attach(isl6423_attach,...) > > fail? > > OK. Attempting, although I have no clue whether such failures are really > fatal or not... > > This is version 2 of this patch, adding cleanup in case we fail to register > the two submodules used by this card/frontend. I'm not certain that this > additional cleanup is appropriate for stable as any failure to register > these will be handled cleanly AFAICS. But I have no way to test this. > > This patch should apply cleanly to 2.6.32, 2.6.33, 2.6.34-rc2 > > This does not apply cleanly to git://linuxtv.org/v4l-dvb.git master. I will > followup with a similar patch for that branch > > Please apply to stable if appropriate. If not, please apply version 1 > of the patch, which fixes only the oops condition. Any reason why this patch isn't in Linus's tree yet? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
